MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ubsan: aarch64: left shift of negative value

Browse Source 
* aarch64-dis.c (sign_extend): Return uint64_t.  Rewrite without
	conditional.
	(aarch64_ext_imm): Avoid signed overflow.
This commit is contained in:
Alan Modra 2019-12-16 16:58:30 +10:30
parent 488d02fe77
commit f81e7e2db6
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opcodes/ChangeLog
View File

@ -1,3 +1,9 @@
2019-12-16 Alan Modra <amodra@gmail.com>
* aarch64-dis.c (sign_extend): Return uint64_t. Rewrite without
conditional.
(aarch64_ext_imm): Avoid signed overflow.
2019-12-16 Alan Modra <amodra@gmail.com>
* microblaze-dis.c (read_insn_microblaze): Avoid signed overflow.

15
opcodes/aarch64-dis.c
View File

@ -178,18 +178,15 @@ extract_all_fields (const aarch64_operand *self, aarch64_insn code)
}
/* Sign-extend bit I of VALUE. */
static inline int32_t
static inline uint64_t
sign_extend (aarch64_insn value, unsigned i)
{
uint32_t ret = value;
uint64_t ret, sign;
assert (i < 32);
if ((value >> i) & 0x1)
{
uint32_t val = (uint32_t)(-1) << i;
ret = ret | val;
}
return (int32_t) ret;
ret = value;
sign = (uint64_t) 1 << i;
return ((ret & (sign + sign - 1)) ^ sign) - sign;
}
/* N.B. the following inline helpfer functions create a dependency on the
@ -658,7 +655,7 @@ aarch64_ext_imm (const aarch64_operand *self, aarch64_opnd_info *info,
const aarch64_inst *inst ATTRIBUTE_UNUSED,
aarch64_operand_error *errors ATTRIBUTE_UNUSED)
{
int64_t imm;
uint64_t imm;
imm = extract_all_fields (self, code);