MatCat.OpenSource/8sa1-binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* i386-tdep.c (i386_extract_struct_value_address): Use

Browse Source 
regcache_raw_read_unsigned instead of
regcache_cooked_read_unsigned since we know that the register
we're reading isn't a pseudo register.  Rename variable 'val' into
the more descriptive 'addr'.
This commit is contained in:
Mark Kettenis 2002-10-26 14:41:37 +00:00
parent 57266a339f
commit 751f1375d6
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,5 +1,11 @@
2002-10-26 Mark Kettenis <kettenis@gnu.org> 2002-10-26 Mark Kettenis <kettenis@gnu.org>
* i386-tdep.c (i386_extract_struct_value_address): Use
regcache_raw_read_unsigned instead of
regcache_cooked_read_unsigned since we know that the register
we're reading isn't a pseudo register. Rename variable 'val' into
the more descriptive 'addr'.
* x86-64-tdep.c: Fix some formatting problems, mostly in comments. * x86-64-tdep.c: Fix some formatting problems, mostly in comments.
(x86_64_push_return_address): Add comment. (x86_64_push_return_address): Add comment.
(x86_64_pop_frame): Make static. (x86_64_pop_frame): Make static.

22
gdb/i386-tdep.c
View File

@ -1039,25 +1039,17 @@ i386_store_return_value (struct type *type, struct regcache *regcache,
} }
} }
/* Extract from an array REGBUF containing the (raw) register state /* Extract from REGCACHE, which contains the (raw) register state, the
the address in which a function should return its structure value, address in which a function should return its structure value, as a
as a CORE_ADDR. */ CORE_ADDR. */
static CORE_ADDR static CORE_ADDR
i386_extract_struct_value_address (struct regcache *regcache) i386_extract_struct_value_address (struct regcache *regcache)
{ {
/* NOTE: cagney/2002-08-12: Replaced a call to ULONGEST addr;
regcache_raw_read_as_address() with a call to
regcache_cooked_read_unsigned(). The old, ...as_address function regcache_raw_read_unsigned (regcache, LOW_RETURN_REGNUM, &addr);
was eventually calling extract_unsigned_integer (via return addr;
extract_address) to unpack the registers value. The below is
doing an unsigned extract so that it is functionally equivalent.
The read needs to be cooked as, otherwise, it will never
correctly return the value of a register in the [NUM_REGS
.. NUM_REGS+NUM_PSEUDO_REGS) range. */
ULONGEST val;
regcache_cooked_read_unsigned (regcache, LOW_RETURN_REGNUM, &val);
return val;
} }